gh-143535: Dispatch on the second argument if generic method is instance-bindable#144615
Open
johnslavik wants to merge 15 commits intopython:mainfrom
Open
gh-143535: Dispatch on the second argument if generic method is instance-bindable#144615johnslavik wants to merge 15 commits intopython:mainfrom
johnslavik wants to merge 15 commits intopython:mainfrom
Conversation
Member
Author
|
@rhettinger, do you like this fix? Or do you like a documentation change more? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unbound methods (i.e. functions) become bound methods when regularly accessed as instance attributes. From the class level, the contract of Python is that the unbound method can be called like a function (the first argument to the call will be used as the conventional
self) and the call will execute directly (no bound method in between). Following the contract, a natural expectation is that when generic methods are called as class attributes, the second argument will be used for dispatching, not the first (the conventionalself).To support descriptors like
classmethod(that bind to something else than the instance), arguments are shifted by one even if__get__method returns a method that is bound to a different object than the originalself(_singledispatchmethod_get._obj). If one wants to receive thatselfin an arbitrary bound method as a regular argument, the workaround is easy: return apartial(bound method)to hack the check.This is a low risk bugfix. The patch is meant to fix the following program:
singledispatchmethoddispatches on first argument to instance-bindable method called from class level #143535